Author serhiy.storchaka
Recipients eric.snow, josh.r, kaniini, methane, python-dev, rhettinger, serhiy.storchaka, xiang.zhang, zach.ware
Date 2016-10-27.08:26:18
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1477556778.87.0.103397610955.issue27275@psf.upfronthosting.co.za>
In-reply-to
Content
In issue28014 __getitem__() is idempotent. Multiple calls of __getitem__() return the same result and keep the OrderedDict in the same state.

> I'd be perfectly happy with making popitem implemented in terms of pop on subclasses when pop is overridden (if pop isn't overridden though, that's effectively what popitem already does).

I like this idea.

> Note: In the expiring case, the fix is still "wrong" if someone used popitem for the intended purpose (to get and delete).

Good catch! But old implementation still looks doubtful to me.
History
Date User Action Args
2016-10-27 08:26:18serhiy.storchakasetrecipients: + serhiy.storchaka, rhettinger, methane, python-dev, eric.snow, zach.ware, josh.r, xiang.zhang, kaniini
2016-10-27 08:26:18serhiy.storchakasetmessageid: <1477556778.87.0.103397610955.issue27275@psf.upfronthosting.co.za>
2016-10-27 08:26:18serhiy.storchakalinkissue27275 messages
2016-10-27 08:26:18serhiy.storchakacreate