Message 279000 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	masamoto
Recipients	masamoto
Date	2016-10-19.23:27:58
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1476919678.71.0.954266925792.issue28480@psf.upfronthosting.co.za>
In-reply-to

Content
_socket module has failed to compile with --without-threads flag since 554fb699af8c, because Py_END_ALLOW_THREADS macro exists behind the done label ( Modules/socketmodule.c:666 ). If --without-threads flag goes on, Py_END_ALLOW_THREADS macro replaces to just right curly bracket. Therefore, between label and end of block have no statements. There needs meaningless statement (e.g. result = result;) to avoid compile error. I wrote a one line patch as a test.

_socket module has failed to compile with --without-threads flag since 554fb699af8c, because Py_END_ALLOW_THREADS macro exists behind the done label ( Modules/socketmodule.c:666 ).

If --without-threads flag goes on, Py_END_ALLOW_THREADS macro replaces to just right curly bracket. Therefore, between label and end of block have no statements. There needs meaningless statement (e.g. result = result;) to avoid compile error.
I wrote a one line patch as a test.

History
Date	User	Action	Args
2016-10-19 23:27:58	masamoto	set	recipients: + masamoto
2016-10-19 23:27:58	masamoto	set	messageid: <1476919678.71.0.954266925792.issue28480@psf.upfronthosting.co.za>
2016-10-19 23:27:58	masamoto	link	issue28480 messages
2016-10-19 23:27:58	masamoto	create