Author martin.panter
Recipients David.Edelsohn, Michael.Felt, aixtools@gmail.com, martin.panter, python-dev
Date 2016-10-14.23:46:31
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1476488791.18.0.0720917715176.issue26439@psf.upfronthosting.co.za>
In-reply-to
Content
Just some minor comments on aix-library.161004.patch:

Instead of _util.py, I wonder if the new file should have a different name, like _util_common.py, to avoid being too similar to util.py.

+def get_shared(input):
+    """Internal support function: examine the get_dumpH() output and
+    return a list of all shareable objects indicated in the output the
+    character "[" is used to strip off the path information.

Needs a newline or new sentance to separate “output” and “the character”.

+def get_legacy(members):
+    [. . .]
+    # shr.o is the preffered name so we look for shr.o first

Spelling: preferred [single F, double R]

+def get_version(name, members):
+    """[. . .]
+    Before the GNU convention became the standard scheme regardless of
+    binary size AIX packagers used GNU convention "as-is" for 32-bit
+    archive members but used an "distinguishing" name for 64-bit members.

Should be: a "distinguishing" [not “an”]
History
Date User Action Args
2016-10-14 23:46:31martin.pantersetrecipients: + martin.panter, python-dev, David.Edelsohn, Michael.Felt, aixtools@gmail.com
2016-10-14 23:46:31martin.pantersetmessageid: <1476488791.18.0.0720917715176.issue26439@psf.upfronthosting.co.za>
2016-10-14 23:46:31martin.panterlinkissue26439 messages
2016-10-14 23:46:31martin.pantercreate