Author berker.peksag
Recipients berker.peksag, brett.cannon, eric.snow, r.david.murray, serhiy.storchaka, xiang.zhang
Date 2016-09-27.15:59:18
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1474991958.76.0.996322544816.issue21578@psf.upfronthosting.co.za>
In-reply-to
Content
Serhiy's patch looks good to me.  It would be nice to add a test for multiple invalid keyword arguments:

    with self.assertRaisesRegex(TypeError, msg):
        ImportError('test', invalid='keyword', another=True)

Using empty_tuple seems reasonable to me. Brett and Eric, what do you think?
History
Date User Action Args
2016-09-27 15:59:18berker.peksagsetrecipients: + berker.peksag, brett.cannon, r.david.murray, eric.snow, serhiy.storchaka, xiang.zhang
2016-09-27 15:59:18berker.peksagsetmessageid: <1474991958.76.0.996322544816.issue21578@psf.upfronthosting.co.za>
2016-09-27 15:59:18berker.peksaglinkissue21578 messages
2016-09-27 15:59:18berker.peksagcreate