Author serhiy.storchaka
Recipients rhettinger, serhiy.storchaka, xiang.zhang
Date 2016-09-26.18:13:46
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1474913626.43.0.560302545775.issue28280@psf.upfronthosting.co.za>
In-reply-to
Content
PyMapping_Keys(), PyMapping_Values() and PyMapping_Items() can return a list or tuple (because they use PySequence_Fast). But end users of this API often work only with lists and raise an exception if corresponding mapping methods return an instance of other type (actually only for tuples). See Modules/posixmodule.c, Modules/_winapi.c, Modules/_sre.c. The type is even not checked in the latter file.

Old documentation said that PyMapping_Keys(o) is equivalent to the Python expression list(o.keys()). Maybe it is worth to make this true. Make PyMapping_Keys(o) etc always returning a list. This could simplify the code that uses this C API. Since keys() etc usually return a dict view, a list or a generator, but not a tuple, this unlikely will cause performance regression.
History
Date User Action Args
2016-09-26 18:13:46serhiy.storchakasetrecipients: + serhiy.storchaka, rhettinger, xiang.zhang
2016-09-26 18:13:46serhiy.storchakasetmessageid: <1474913626.43.0.560302545775.issue28280@psf.upfronthosting.co.za>
2016-09-26 18:13:46serhiy.storchakalinkissue28280 messages
2016-09-26 18:13:46serhiy.storchakacreate