This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author Ondřej Medek
Recipients Ondřej Medek
Date 2016-09-02.08:33:08
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1472805188.28.0.230242025346.issue27937@psf.upfronthosting.co.za>
In-reply-to
Content
The logging.getLevelName contains code:

return _levelToName.get(level, _nameToLevel.get(level, ("Level %s" % level)))

I am still a Python beginner, but I think the most of the times the _nameToLevel.get is called unnecessarily. IMHO the code should be

return _levelToName.get(level, (_nameToLevel.get(level, ("Level %s" % level))))

or maybe better a classic if then style:
result = _levelToName.get(level)
if result is None:
   result = _nameToLevel.get(level, ("Level %s" % level))
return result

Since this function is called every time the LogRecord is created, I think it should be microoptimized.
History
Date User Action Args
2016-09-02 08:33:08Ondřej Medeksetrecipients: + Ondřej Medek
2016-09-02 08:33:08Ondřej Medeksetmessageid: <1472805188.28.0.230242025346.issue27937@psf.upfronthosting.co.za>
2016-09-02 08:33:08Ondřej Medeklinkissue27937 messages
2016-09-02 08:33:08Ondřej Medekcreate