Message274210
The logging.getLevelName contains code:
return _levelToName.get(level, _nameToLevel.get(level, ("Level %s" % level)))
I am still a Python beginner, but I think the most of the times the _nameToLevel.get is called unnecessarily. IMHO the code should be
return _levelToName.get(level, (_nameToLevel.get(level, ("Level %s" % level))))
or maybe better a classic if then style:
result = _levelToName.get(level)
if result is None:
result = _nameToLevel.get(level, ("Level %s" % level))
return result
Since this function is called every time the LogRecord is created, I think it should be microoptimized. |
|
Date |
User |
Action |
Args |
2016-09-02 08:33:08 | Ondřej Medek | set | recipients:
+ Ondřej Medek |
2016-09-02 08:33:08 | Ondřej Medek | set | messageid: <1472805188.28.0.230242025346.issue27937@psf.upfronthosting.co.za> |
2016-09-02 08:33:08 | Ondřej Medek | link | issue27937 messages |
2016-09-02 08:33:08 | Ondřej Medek | create | |
|