Author terry.reedy
Recipients markroseman, ned.deily, python-dev, terry.reedy
Date 2016-08-10.23:42:51
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1470872571.46.0.829976570878.issue27714@psf.upfronthosting.co.za>
In-reply-to
Content
The issue with test_textview in 3.x is that tearDownModule deleted a module attribute, 'TV', that was not created in setUpModule.  For 2.7, 'TV' is a class attribute that is created in setUpClass and deleted in tearDownClass, so it does not have the same problem.  On the other hand, 'TV' is the original textView.TextViewer class, as modified with mocks in setUpClass.  The modifications are not reverted in tearDownClass.  This is the original code, later modified in 3.x.  This is safe both for re-runs and likely future tests, but this is not immediately obvious.  In any case, it violates the idea/rule that tests should not make permanent changes.  So I backported the local subclass of TextViewer used in 3.x.
History
Date User Action Args
2016-08-10 23:42:51terry.reedysetrecipients: + terry.reedy, ned.deily, markroseman, python-dev
2016-08-10 23:42:51terry.reedysetmessageid: <1470872571.46.0.829976570878.issue27714@psf.upfronthosting.co.za>
2016-08-10 23:42:51terry.reedylinkissue27714 messages
2016-08-10 23:42:51terry.reedycreate