Author rhettinger
Recipients rhettinger, serhiy.storchaka, xiang.zhang
Date 2016-08-07.22:28:30
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1470608911.5.0.706789656962.issue27703@psf.upfronthosting.co.za>
In-reply-to
Content
Have you checked all the possibly code paths to be sure?   "Seems to be unnecessary" is insufficient reason for undoing Guido's code that has stood since 1997.   


Looking at the snarl of possible code paths, I not finding it obvious why some of the paths require Py_XDECREF and others don't.   Even if you are sure, then the patch needs to include assertions at key checkpoints (i.e. after a given assignment to "type" or "value" can we reliably assert the value is non-null) and/or comments showing what the reasoning is.  Otherwise, even if the patch happens to be correct, it increases the risk that future maintenance will introduce a bug when the current code would have allowed the maintenance in a safer context.
History
Date User Action Args
2016-08-07 22:28:31rhettingersetrecipients: + rhettinger, serhiy.storchaka, xiang.zhang
2016-08-07 22:28:31rhettingersetmessageid: <1470608911.5.0.706789656962.issue27703@psf.upfronthosting.co.za>
2016-08-07 22:28:31rhettingerlinkissue27703 messages
2016-08-07 22:28:30rhettingercreate