Author martin.panter
Recipients Lukasa, martin.panter, orsenthil, remram
Date 2016-07-21.01:54:17
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1469066058.24.0.504605571166.issue27568@psf.upfronthosting.co.za>
In-reply-to
Content
I think I misunderstood the Windows situation. Now I understand Windows has no lower-case variable names, so this patch would stop accepting any HTTP_PROXY variable there (in CGI mode). But that is okay by me.

I agree the mixed-case scenario is not worth worrying too much about. The normal scenario is all lowercase (http_proxy), and I think all-uppercase (HTTP_PROXY) is only supported for compatibility with some older browsers or OSes (can’t remember the details). However, since we already document “a case-insensitive approach”, perhaps it needs tweaking somehow. Perhaps it would be more correct to say, in CGI mode:

* Only lowercase _proxy suffix is accepted (stricter than just ignoring uppercase)
* No variable is accepted where names must be uppercase, i.e. Windows. As I understand it, you cannot have a lowercase http_proxy variable there.

Also, I think the “note” additions should be indented under the getproxies() etc headings. (Or drop the markup and make it an ordinary sentence or paragraph. “Note that” is also redundant IMO.)
History
Date User Action Args
2016-07-21 01:54:18martin.pantersetrecipients: + martin.panter, orsenthil, Lukasa, remram
2016-07-21 01:54:18martin.pantersetmessageid: <1469066058.24.0.504605571166.issue27568@psf.upfronthosting.co.za>
2016-07-21 01:54:18martin.panterlinkissue27568 messages
2016-07-21 01:54:17martin.pantercreate