Author vstinner
Recipients berker.peksag, ezio.melotti, georg.brandl, lisroach, python-dev, r.david.murray, rhettinger, vstinner, willingc, zach.ware
Date 2016-07-20.22:40:24
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1469054424.53.0.907955903447.issue23951@psf.upfronthosting.co.za>
In-reply-to
Content
Berker Peksag
> -1. I think the current devguide theme looks fine and it would be nice to keep devguide and Python documentations use different themes.

I pushed the change because there were 3 positive votes and no negative vote, and I like the proposed them.


> I'd be -0 if the patch was small, but diff stat "11 files changed, 1651 insertions(+), 10 deletions(-)" is huge and it would be nice to avoid  code duplication. The current theme has some bugs and now we will have to update two different repos everytime we touch the docs.p.o theme.

Sorry but I don't know anything about Sphinx theme. If you know how to fix mentionned issues, please write a patch and/or push directly changes.


> It seems like devguide_theme_revised.patch was committed accidentally: https://hg.python.org/devguide/rev/9e7b1bc15ba7#l3.3

What do you mean? It was deliberate for me to push devguide_theme_revised.patch. I don't see strong reason in comments to not push the change.


> I'd also delete rstllint.py.

It adds a new "make check" which doesn't hurt.

Maybe it may be better to contribute to Sphinx, but again, it's short and doesn't hurt.
History
Date User Action Args
2016-07-20 22:40:24vstinnersetrecipients: + vstinner, georg.brandl, rhettinger, ezio.melotti, r.david.murray, python-dev, berker.peksag, zach.ware, willingc, lisroach
2016-07-20 22:40:24vstinnersetmessageid: <1469054424.53.0.907955903447.issue23951@psf.upfronthosting.co.za>
2016-07-20 22:40:24vstinnerlinkissue23951 messages
2016-07-20 22:40:24vstinnercreate