Message 270515 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	ddorda
Recipients	ddorda
Date	2016-07-15.21:14:53
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1468617293.43.0.813584223225.issue27525@psf.upfronthosting.co.za>
In-reply-to

Content
The gzip module generates files with wrong OS header, by putting "Unknown" OS, instead of checking and filling the user's OS. From the gzip RFC (rfc1952): "This identifies the type of file system on which compression took place. This may be useful in determining end-of-line convention for text files." The following patch contains a fix that fills the current OS flag (and testcase ;) ) * The bug is relevant to python 2.x too, but I did not test the patch on it. ** also, I did not run the testcase on Win/Mac, however it should work.

The gzip module generates files with wrong OS header, by putting "Unknown" OS, instead of checking and filling the user's OS.
From the gzip RFC (rfc1952): "This identifies the type of file system on which compression took place. This may be useful in determining end-of-line convention for text files."

The following patch contains a fix that fills the current OS flag (and testcase ;) )

* The bug is relevant to python 2.x too, but I did not test the patch on it.
** also, I did not run the testcase on Win/Mac, however it should work.

History
Date	User	Action	Args
2016-07-15 21:14:53	ddorda	set	recipients: + ddorda
2016-07-15 21:14:53	ddorda	set	messageid: <1468617293.43.0.813584223225.issue27525@psf.upfronthosting.co.za>
2016-07-15 21:14:53	ddorda	link	issue27525 messages
2016-07-15 21:14:53	ddorda	create