➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author nascheme
Recipients SilentGhost, martin.panter, nascheme
Date 2016-07-14.17:19:36
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1468516776.5.0.561829363878.issue27377@psf.upfronthosting.co.za>
In-reply-to
Content 
I just tested on Windows.  fdtype() fails with:
OSError: [WinError 10022] An invalid argument was supplied

The getsockname() call fails with WSAGetLastError() == 10022.  getsockname() is used to find the address family.  Perhaps there is some other way to get it on Windows.

The easiest fix would be to #ifdef MS_WINDOWS out the whole socket_fdtype() function.  Passing file descriptors around is not a thing on Windows anyhow.

There is still the issue of unexpected errors getting returned inside fdtype() (e.g. as suggested by Martin).  One idea is to commit the code as is and fix errors as they appear.
History
Date User Action Args
2016-07-14 17:19:36naschemesetrecipients: + nascheme, SilentGhost, martin.panter
2016-07-14 17:19:36naschemesetmessageid: <1468516776.5.0.561829363878.issue27377@psf.upfronthosting.co.za>
2016-07-14 17:19:36naschemelinkissue27377 messages
2016-07-14 17:19:36naschemecreate