Message 269925 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	xdegaye
Recipients	Alex.Willmer, doko, vstinner, xdegaye
Date	2016-07-07.07:17:58
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1467875878.42.0.252517908362.issue27434@psf.upfronthosting.co.za>
In-reply-to

Content
I think the way the condition was written previously is more expressive, so the patch does not change that. The 'not' here expresses the fact that in the shell syntax, the condition is true when the test returns 0 [1], but we still want to express the fact that the 'break' is taken when the interpreter version matches $PACKAGE_VERSION. [1] https://www.gnu.org/software/bash/manual/html_node/Conditional-Constructs.html#Conditional-Constructs

I think the way the  condition was written previously is more expressive, so the patch does not change that. The 'not' here expresses the fact that in the shell syntax, the condition is true when the test returns 0 [1], but we still want to express the fact that the 'break' is taken when the interpreter version matches $PACKAGE_VERSION.

[1] https://www.gnu.org/software/bash/manual/html_node/Conditional-Constructs.html#Conditional-Constructs

History
Date	User	Action	Args
2016-07-07 07:17:58	xdegaye	set	recipients: + xdegaye, doko, vstinner, Alex.Willmer
2016-07-07 07:17:58	xdegaye	set	messageid: <1467875878.42.0.252517908362.issue27434@psf.upfronthosting.co.za>
2016-07-07 07:17:58	xdegaye	link	issue27434 messages
2016-07-07 07:17:58	xdegaye	create