Author takluyver
Recipients Dhiraj_Mishra, martin.panter, mbussonn, python-dev, serhiy.storchaka, takluyver
Date 2016-05-14.21:25:05
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1463261105.91.0.33667636107.issue26039@psf.upfronthosting.co.za>
In-reply-to
Content
1. For the cases like read/write handles conflicting, ValueError doesn't seem quite right to me - I take ValueError to mean that you have passed an invalid value to a function. RuntimeError feels like the closest fit for 'the current state does not allow this operation'. It is rather broad, though.

If I was writing it anew, I would use ValueError for something like an invalid mode parameter: zf.open('foo', mode='q') . That particular case was already in the code, though, so I think backwards compatibility should take precedence.

2 & 3. Agreed, I'll prepare a patch
History
Date User Action Args
2016-05-14 21:25:05takluyversetrecipients: + takluyver, python-dev, martin.panter, serhiy.storchaka, mbussonn, Dhiraj_Mishra
2016-05-14 21:25:05takluyversetmessageid: <1463261105.91.0.33667636107.issue26039@psf.upfronthosting.co.za>
2016-05-14 21:25:05takluyverlinkissue26039 messages
2016-05-14 21:25:05takluyvercreate