Author vstinner
Recipients Arfrever, berker.peksag, brett.cannon, eric.snow, r.david.murray, serhiy.storchaka, vstinner
Date 2016-03-25.12:07:24
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1458907645.42.0.337473409266.issue20021@psf.upfronthosting.co.za>
In-reply-to
Content
> Victor went with a different solution in f682b620c64d.

Oh sorry, I wasn't aware of this old issue. My motivation was to get ride of the deprecated imp module, this script looks to be the latest part of the Python which uses the imp module (except of deliberate unit tests on the imp module).


> f682b620c64d looks incorrect to me. It makes makeopcodetargets.py to use the opcode module of Python that executes the script. Instead the script should use the opcode module from the same source tree as the script.

Ah, this was unclear to me. It looks overcomplicated code to just import a module. Can't we simply use import, but ensure that the running python executable belongs to the current source tree?

Or does it matter to be able to use an external python program?


> I think f682b620c64d should be reverted.

Don't hesitate to rework the code to importlib if you want to ensure that Lib/opcode.py is imported.

But please don't revert the whole change, I changed other things.
History
Date User Action Args
2016-03-25 12:07:25vstinnersetrecipients: + vstinner, brett.cannon, Arfrever, r.david.murray, eric.snow, berker.peksag, serhiy.storchaka
2016-03-25 12:07:25vstinnersetmessageid: <1458907645.42.0.337473409266.issue20021@psf.upfronthosting.co.za>
2016-03-25 12:07:25vstinnerlinkissue20021 messages
2016-03-25 12:07:24vstinnercreate