Message262131
> What about alignment issues on strict platforms? (SPARC?)
Which kind of alignment issue do you expect?
I added "__attribute__((packed))" to frame_t. I expected SIGBUS because of that (it's even documented in a comment ;-)), but I practice nobdy complained, not even our buildbots. Hum, it looks like we only have one SPARC buildbot and it's offline...
_Py_hashtable_get() uses memcpy() to copy the value, so this function should not have any alignment issue.
The new code uses pointer dereference, so alignment issues are more likely. How can I test it on Intel CPU?
Should I also use memcpy() to retrieve the key value? |
|
Date |
User |
Action |
Args |
2016-03-21 14:54:52 | vstinner | set | recipients:
+ vstinner, pitrou, njs |
2016-03-21 14:54:52 | vstinner | set | messageid: <1458572092.88.0.248002598258.issue26588@psf.upfronthosting.co.za> |
2016-03-21 14:54:52 | vstinner | link | issue26588 messages |
2016-03-21 14:54:52 | vstinner | create | |
|