Message261669
- now = time.time()
- year, month, day, hh, mm, ss, x, y, z = time.localtime(now)
- s = "%02d/%3s/%04d %02d:%02d:%02d" % (
- day, self.monthname[month], year, hh, mm, ss)
+ s = time.strftime("%d/%b/%Y %H:%M:%S", time.localtime())
This part of the patch is incorrect. time.strftime() will return non-English values for different locales.
About deprecations of weekdayname and monthname attributes:
I know that they are undocumented, but they are already being used in the wild. For example, see https://github.com/natemago/srv/blob/master/srv.py#L419 Since we don't have any public API for this use case, I'd be +1 to keep them for now.
Here is an updated patch. |
|
Date |
User |
Action |
Args |
2016-03-13 01:24:09 | berker.peksag | set | recipients:
+ berker.peksag, barry, anthonybaxter, gaul, dalke, orsenthil, ajaksu2, eric.araujo, r.david.murray, karlcow, l0nwlf |
2016-03-13 01:24:08 | berker.peksag | set | messageid: <1457832248.91.0.756905531097.issue747320@psf.upfronthosting.co.za> |
2016-03-13 01:24:08 | berker.peksag | link | issue747320 messages |
2016-03-13 01:24:08 | berker.peksag | create | |
|