Author berker.peksag
Recipients ajaksu2, anthonybaxter, barry, berker.peksag, dalke, eric.araujo, gaul, karlcow, l0nwlf, orsenthil, r.david.murray
Date 2016-03-13.01:24:05
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1457832248.91.0.756905531097.issue747320@psf.upfronthosting.co.za>
In-reply-to
Content
-        now = time.time()
-        year, month, day, hh, mm, ss, x, y, z = time.localtime(now)
-        s = "%02d/%3s/%04d %02d:%02d:%02d" % (
-                day, self.monthname[month], year, hh, mm, ss)
+        s = time.strftime("%d/%b/%Y %H:%M:%S", time.localtime())

This part of the patch is incorrect. time.strftime() will return non-English values for different locales.

About deprecations of weekdayname and monthname attributes:

I know that they are undocumented, but they are already being used in the wild. For example, see https://github.com/natemago/srv/blob/master/srv.py#L419 Since we don't have any public API for this use case, I'd be +1 to keep them for now.

Here is an updated patch.
History
Date User Action Args
2016-03-13 01:24:09berker.peksagsetrecipients: + berker.peksag, barry, anthonybaxter, gaul, dalke, orsenthil, ajaksu2, eric.araujo, r.david.murray, karlcow, l0nwlf
2016-03-13 01:24:08berker.peksagsetmessageid: <1457832248.91.0.756905531097.issue747320@psf.upfronthosting.co.za>
2016-03-13 01:24:08berker.peksaglinkissue747320 messages
2016-03-13 01:24:08berker.peksagcreate