Message260524
Currently if you call server_close you only close the socket. If we called serve_forever and then call server_close without calling shutdown the serve_forever loop keep running. Before using the selectors module for doing the poll we would have had exception thrown from the select (The socket fd is -1) in serve_forever.
IMO you should be able to call server_close at any time and expect it to stop the serve_forever. Maybe even adding a block option to server_close that will wait on the server_forever if it's running (waiting for issue 12463 to resolve before doing this).
Added a patch that closes serve_forever if server_close is called. |
|
Date |
User |
Action |
Args |
2016-02-19 17:00:17 | palaviv | set | recipients:
+ palaviv |
2016-02-19 17:00:17 | palaviv | set | messageid: <1455901217.04.0.582313607927.issue26392@psf.upfronthosting.co.za> |
2016-02-19 17:00:16 | palaviv | link | issue26392 messages |
2016-02-19 17:00:16 | palaviv | create | |
|