This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author martin.panter
Recipients berker.peksag, desbma, docs@python, martin.panter, vstinner, yselivanov
Date 2016-02-18.00:37:21
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1455755843.01.0.500157994158.issue24911@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks for the reviews.

In this new patch, I modified two existing examples, but did not add any new example. Does that work for you Yury?

Also modified example code for the socketserver module.

Victor: IMO the “with conn” in the example is not overkill. It ensures the client connection socket is cleaned up, which is completely independent of the server listening socket s.

What exceptions can you get out of conn.close()? I can only think of unusual programming errors like EBADF. I would prefer to remove close() as being redundant with the context manager.
History
Date User Action Args
2016-02-18 00:37:23martin.pantersetrecipients: + martin.panter, vstinner, docs@python, berker.peksag, desbma, yselivanov
2016-02-18 00:37:23martin.pantersetmessageid: <1455755843.01.0.500157994158.issue24911@psf.upfronthosting.co.za>
2016-02-18 00:37:22martin.panterlinkissue24911 messages
2016-02-18 00:37:22martin.pantercreate