Author terry.reedy
Recipients markroseman, terry.reedy
Date 2016-01-27.16:49:13
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1453913353.26.0.405019425899.issue25507@psf.upfronthosting.co.za>
In-reply-to
Content
Ouch.  Moving the idleConf import was a blunder.  It disabled printing in 2.7.11, 3.4.4, and 3.5.1.  When I revert, I will also augment the htest to test the printing and save-as functions.  Still have to remember to run it though.

This sort of functional test is not the main intended use of htests.  When refactoring for this issue, automated tests should be added, with mocks used to avoid consequential actions that cannot be part of a buildbot test.  For print_window, '''pipe = os.popen(command, "r")''' (https://hg.python.org/cpython/file/tip/Lib/idlelib/IOBinding.py#l463) should be replaced by '''pipe = runcommand(command)''' and 'def runcommand(command): return os.pipe(command, 'r')''' (with subprocess used instead?) added at module level.  Then runcommand can be replaced by a mock when testing, and the value of the passed command checked.
History
Date User Action Args
2016-01-27 16:49:13terry.reedysetrecipients: + terry.reedy, markroseman
2016-01-27 16:49:13terry.reedysetmessageid: <1453913353.26.0.405019425899.issue25507@psf.upfronthosting.co.za>
2016-01-27 16:49:13terry.reedylinkissue25507 messages
2016-01-27 16:49:13terry.reedycreate