Author gvanrossum
Recipients gvanrossum, michael.foord, miyakogi, vstinner, yselivanov
Date 2016-01-22.19:28:59
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <CAP7+vJJ5Zdb2upQJ-a+0QA6UnBbO2roBz3D6DHn2d2g9CF_8Ww@mail.gmail.com>
In-reply-to <1453261574.88.0.59851332474.issue26140@psf.upfronthosting.co.za>
Content
Am I really still needed on this issue?

On Tue, Jan 19, 2016 at 7:46 PM, Hiroyuki Takagi <report@bugs.python.org>
wrote:

>
> Hiroyuki Takagi added the comment:
>
> Thank you for reviewing patch.
>
> I wrote test and updated patch. To pass the test, both this patch and
> issue25599's patch are required.
>
> Changes of the patch:
> - copy __code__ not only functions but also methods
> - add autospec (create_autospec) suppoort
>
> I have completely missed about autospec, thank you for a mention about it.
> For autospec, simply copying original __code__ to funcopy makes error on
> existing tests.
> That's why I changed the src of exec, but it seems to be quite ad-hoc. It
> may be better to be improved, but I don't have any good idea, sorry.
>
> On the tests of this patch, I wonder if it's better to use assertIs(..,
> True/False) instead of assertTrue/False, since it was one of the problem in
> issue25599.
> To apply this change and pass test, need to change
> asyncio.iscoroutinefunction to return bool. The change would be very easy,
> just update issue25599's patch like `return_value = bool(getattr(func, ...`.
>
> ----------
> Added file: http://bugs.python.org/file41664/mock2.patch
>
> _______________________________________
> Python tracker <report@bugs.python.org>
> <http://bugs.python.org/issue26140>
> _______________________________________
>
History
Date User Action Args
2016-01-22 19:28:59gvanrossumsetrecipients: + gvanrossum, vstinner, michael.foord, yselivanov, miyakogi
2016-01-22 19:28:59gvanrossumlinkissue26140 messages
2016-01-22 19:28:59gvanrossumcreate