Author Charles Daffern
Recipients Charles Daffern
Date 2016-01-15.13:14:40
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <>
The shlex.quote and pipes.quote functions do not quote shell keywords.

Example shell keywords: done, time, coproc, while

Presumably the intent of the quote functions is to prevent the resulting string from altering the syntax of the script it is inserted into, which is why I think these need to be quoted.

We can't possibly know every shell keyword, so the only sensible thing to do here is to quote everything.
Date User Action Args
2016-01-15 13:14:41Charles Daffernsetrecipients: + Charles Daffern
2016-01-15 13:14:41Charles Daffernsetmessageid: <>
2016-01-15 13:14:41Charles Daffernlinkissue26124 messages
2016-01-15 13:14:40Charles Dafferncreate