Author serhiy.storchaka
Recipients benhoyt, gvanrossum, larry, serhiy.storchaka, vstinner
Date 2016-01-11.21:35:22
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1452548122.1.0.103553265034.issue25995@psf.upfronthosting.co.za>
In-reply-to
Content
Both patches are basically equivalent. The first one collects all scandir() results in a list, the second one collects only directory names in a list. The purpose of using os.scandir() in os.walk() was a speed up (issue23605), and both patches preserve it.

Yes, the number of FDs used is equivalent to the depth of the tree which can be very deep (I just created a tree depth of 1000 levels). And what is worse, all these FDs can be effectively leaked if the walking was not finished. This is unwanted behavior change.
History
Date User Action Args
2016-01-11 21:35:22serhiy.storchakasetrecipients: + serhiy.storchaka, gvanrossum, vstinner, larry, benhoyt
2016-01-11 21:35:22serhiy.storchakasetmessageid: <1452548122.1.0.103553265034.issue25995@psf.upfronthosting.co.za>
2016-01-11 21:35:22serhiy.storchakalinkissue25995 messages
2016-01-11 21:35:22serhiy.storchakacreate