Message 255984 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	nchammas
Recipients	brett.cannon, docs@python, nchammas
Date	2015-12-05.22:02:14
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1449352934.38.0.293861730963.issue25768@psf.upfronthosting.co.za>
In-reply-to

Content
Absolutely. I'll add a "bad source file" to `setUp()` [0] and check return values as part of the existing checks in `test_compile_files()` [1]. Does that sound like a good plan to you? Also, I noticed that `compile_path()` has no tests. Should I test it as part of `test_compile_files()` or as part of a different test function? [0] https://hg.python.org/cpython/file/tip/Lib/test/test_compileall.py#l14 [1] https://hg.python.org/cpython/file/tip/Lib/test/test_compileall.py#l57

Absolutely. I'll add a "bad source file" to `setUp()` [0] and check return values as part of the existing checks in `test_compile_files()` [1].

Does that sound like a good plan to you?

Also, I noticed that `compile_path()` has no tests. Should I test it as part of `test_compile_files()` or as part of a different test function?

[0] https://hg.python.org/cpython/file/tip/Lib/test/test_compileall.py#l14
[1] https://hg.python.org/cpython/file/tip/Lib/test/test_compileall.py#l57

History
Date	User	Action	Args
2015-12-05 22:02:14	nchammas	set	recipients: + nchammas, brett.cannon, docs@python
2015-12-05 22:02:14	nchammas	set	messageid: <1449352934.38.0.293861730963.issue25768@psf.upfronthosting.co.za>
2015-12-05 22:02:14	nchammas	link	issue25768 messages
2015-12-05 22:02:14	nchammas	create