This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author lemburg
Recipients ThomasH, alexandre.vassalotti, lemburg, serhiy.storchaka
Date 2015-12-02.21:53:15
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <565F6846.5030303@egenix.com>
In-reply-to <1449088148.7.0.819396670898.issue6395@psf.upfronthosting.co.za>
Content
On 02.12.2015 21:29, Serhiy Storchaka wrote:
> 
> Serhiy Storchaka added the comment:
> 
>> I think all we need to do is add a .__reduce__()
>> method to StreamWriter and StreamReader, which then
>> raises a PickleError.
> 
> Rather TypeError. Yes, it is the least that we should to do in maintained releases. If codecs_stream_delegating_2.patch is considered too drastic for bugfix. But this can be only a part of problem. May be there are issues with other optional special methods. And adding __reduce_ex__ breaks subclass pickleability if it was implemented with __getstate__ and __getnewargs__.
> 
> Here is a patch for this way.

Thanks. I think using __reduce__ instead of __reduce_ex__ is
safer, since subclasses will more likely override __reduce__
than __reduce_ex__.

The other approach will have too many backwards incompatible side
effects, e.g. the repr() over StreamReader instances would change.
History
Date User Action Args
2015-12-02 21:53:15lemburgsetrecipients: + lemburg, alexandre.vassalotti, ThomasH, serhiy.storchaka
2015-12-02 21:53:15lemburglinkissue6395 messages
2015-12-02 21:53:15lemburgcreate