Message 255774 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	serhiy.storchaka
Recipients	ThomasH, alexandre.vassalotti, lemburg, serhiy.storchaka
Date	2015-12-02.20:29:08
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1449088148.7.0.819396670898.issue6395@psf.upfronthosting.co.za>
In-reply-to

Content
> I think all we need to do is add a .__reduce__() > method to StreamWriter and StreamReader, which then > raises a PickleError. Rather TypeError. Yes, it is the least that we should to do in maintained releases. If codecs_stream_delegating_2.patch is considered too drastic for bugfix. But this can be only a part of problem. May be there are issues with other optional special methods. And adding __reduce_ex__ breaks subclass pickleability if it was implemented with __getstate__ and __getnewargs__. Here is a patch for this way.

> I think all we need to do is add a .__reduce__()
> method to StreamWriter and StreamReader, which then
> raises a PickleError.

Rather TypeError. Yes, it is the least that we should to do in maintained releases. If codecs_stream_delegating_2.patch is considered too drastic for bugfix. But this can be only a part of problem. May be there are issues with other optional special methods. And adding __reduce_ex__ breaks subclass pickleability if it was implemented with __getstate__ and __getnewargs__.

Here is a patch for this way.

History
Date	User	Action	Args
2015-12-02 20:29:08	serhiy.storchaka	set	recipients: + serhiy.storchaka, lemburg, alexandre.vassalotti, ThomasH
2015-12-02 20:29:08	serhiy.storchaka	set	messageid: <1449088148.7.0.819396670898.issue6395@psf.upfronthosting.co.za>
2015-12-02 20:29:08	serhiy.storchaka	link	issue6395 messages
2015-12-02 20:29:08	serhiy.storchaka	create