Author martin.panter
Recipients Arfrever, doko, martin.panter, vstinner
Date 2015-11-28.02:29:16
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1448677757.12.0.794508241664.issue25696@psf.upfronthosting.co.za>
In-reply-to
Content
I agree your patches should fix your practical bug (I can reproduce it, two out of three times). My concern is more about making the code cleaner and less likely to grow problems in the future. :) The worse case with patch 3 would be the “Creating directory” message being echoed twice. I am just trying to get the makefile cleaner.

If that block compiled a file, instead of just creating a directory, then it would be a worse problem. The second compile command could truncate the first version, causing errors later on.

Also, I don’t believe adding the dash (-) prefix is a good idea here. It tells Make to keep going even if the command failed. In this case, if the directory already exists, the “if” statement will succeed, and the only way it can fail is if $(INSTALL) fails, which I think we would want to know about. The original “for” loop under libainstall does not include a dash.

bininstall-4.patch implements my suggestion from before.
History
Date User Action Args
2015-11-28 02:29:17martin.pantersetrecipients: + martin.panter, doko, vstinner, Arfrever
2015-11-28 02:29:17martin.pantersetmessageid: <1448677757.12.0.794508241664.issue25696@psf.upfronthosting.co.za>
2015-11-28 02:29:17martin.panterlinkissue25696 messages
2015-11-28 02:29:16martin.pantercreate