This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author martin.panter
Recipients Arfrever, doko, martin.panter, vstinner
Date 2015-11-25.23:58:23
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <>
$(LIBPC) is a single directory name, so I suggest dropping the “for” loop.

Patch 2 should avoid the practical race condition. But there is technically still a race with “libainstall” and “bininstall” both testing and creating the same directory. Maybe we should factor it out, something like:

	@echo "Creating directory $@"
	@$(INSTALL) -d -m $(DIRMODE) $@
. . .
bininstall: altbininstall $(DESTDIR)$(LIBPC)
. . .
libainstall: all python-config $(DESTDIR)$(LIBPC)
	@for i in $(LIBDIR) $(LIBPL); \
	. . .

Looking at the history, the test-then-install code comes from 20 years ago: <>. I would say calling install unconditionally (without a test or echo message) might be simpler, but that’s probably getting out of scope here.
Date User Action Args
2015-11-25 23:58:23martin.pantersetrecipients: + martin.panter, doko, vstinner, Arfrever
2015-11-25 23:58:23martin.pantersetmessageid: <>
2015-11-25 23:58:23martin.panterlinkissue25696 messages
2015-11-25 23:58:23martin.pantercreate