Author serhiy.storchaka
Recipients Unit03, berker.peksag, martin.panter, maurosr, milap.py, python-dev, r.david.murray, selik, serhiy.storchaka, taddeimania
Date 2015-11-10.07:20:02
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1447140003.21.0.6572988823.issue23883@psf.upfronthosting.co.za>
In-reply-to
Content
I have added comments on Rietveld. Besides few stylistic nitpicks Issue23883_support_check__all__.v5.patch LGTM.

> But passing "self" to it feels a bit weird.

This is not new. There are other testing helpers in test.support that needs passing "self". If the helper is used many times in one test class, I prefer to make a method:

    class SomeTest(TestCase):
        check_something = test.support.check_something

        def test_foo():
            self.check_something('foo')

        def test_bar():
            self.check_something('bar')

But in this case I'm happy with the current API.
History
Date User Action Args
2015-11-10 07:20:03serhiy.storchakasetrecipients: + serhiy.storchaka, r.david.murray, python-dev, berker.peksag, martin.panter, milap.py, maurosr, taddeimania, Unit03, selik
2015-11-10 07:20:03serhiy.storchakasetmessageid: <1447140003.21.0.6572988823.issue23883@psf.upfronthosting.co.za>
2015-11-10 07:20:03serhiy.storchakalinkissue23883 messages
2015-11-10 07:20:02serhiy.storchakacreate