Message254434
I have added comments on Rietveld. Besides few stylistic nitpicks Issue23883_support_check__all__.v5.patch LGTM.
> But passing "self" to it feels a bit weird.
This is not new. There are other testing helpers in test.support that needs passing "self". If the helper is used many times in one test class, I prefer to make a method:
class SomeTest(TestCase):
check_something = test.support.check_something
def test_foo():
self.check_something('foo')
def test_bar():
self.check_something('bar')
But in this case I'm happy with the current API. |
|
Date |
User |
Action |
Args |
2015-11-10 07:20:03 | serhiy.storchaka | set | recipients:
+ serhiy.storchaka, r.david.murray, python-dev, berker.peksag, martin.panter, milap.py, maurosr, taddeimania, Unit03, selik |
2015-11-10 07:20:03 | serhiy.storchaka | set | messageid: <1447140003.21.0.6572988823.issue23883@psf.upfronthosting.co.za> |
2015-11-10 07:20:03 | serhiy.storchaka | link | issue23883 messages |
2015-11-10 07:20:02 | serhiy.storchaka | create | |
|