Author eric.smith
Recipients Mark.Shannon, brett.cannon, eric.smith, larry, serhiy.storchaka
Date 2015-11-02.14:10:06
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1446473406.6.0.720995593356.issue25483@psf.upfronthosting.co.za>
In-reply-to
Content
Right, they're the same because it's a single bit. You 'and' with a mask to get the bits you want, and you 'or' together the values. It's an old habit left over from my bit-twiddling days.

I guess the test could really be:

have_fmt_spec = (oparg & FVS_MASK) == FVS_HAVE_SPEC;

to make it more clear what I'm doing.

It's easier to see the same thing with the FVC_MASK and FVC_* values, since that field is multiple bits.
History
Date User Action Args
2015-11-02 14:10:06eric.smithsetrecipients: + eric.smith, brett.cannon, larry, Mark.Shannon, serhiy.storchaka
2015-11-02 14:10:06eric.smithsetmessageid: <1446473406.6.0.720995593356.issue25483@psf.upfronthosting.co.za>
2015-11-02 14:10:06eric.smithlinkissue25483 messages
2015-11-02 14:10:06eric.smithcreate