Author martin.panter
Recipients desbma, josh.r, martin.panter, r.david.murray
Date 2015-10-31.07:36:32
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1446276993.19.0.0340860976938.issue25156@psf.upfronthosting.co.za>
In-reply-to
Content
I left a few comments. But it might be good if someone more familiar with the APIs could review this.

Have you seen the socket.sendfile() implementation? It’s a bit of a mess, and the circumstances are slightly different, but it may offer partial inspiration. It seems a shame to have two separate high-level sendfile() wrappers, but I guess the use cases are just a little too far apart to be worth sharing much code.

For the test case, it may be worth skipping the test if you run out of disk space. Similar to test_mmap and test_largefile.
History
Date User Action Args
2015-10-31 07:36:33martin.pantersetrecipients: + martin.panter, r.david.murray, desbma, josh.r
2015-10-31 07:36:33martin.pantersetmessageid: <1446276993.19.0.0340860976938.issue25156@psf.upfronthosting.co.za>
2015-10-31 07:36:33martin.panterlinkissue25156 messages
2015-10-31 07:36:32martin.pantercreate