Message253359
Patch doesn't let me comment, but I believe to be strictly standards conformant, sigwinch_received should be declared as a `volatile sig_atomic_t`, not `char`. See: https://www.securecoding.cert.org/confluence/display/c/SIG31-C.+Do+not+access+shared+objects+in+signal+handlers
Also, to close an incredibly narrow race window, I believe sigwinch_received should be set to zero before calling rl_resize_terminal(), on the theory that otherwise, the signal could be received just after the call, but before setting the flag to 0, the signal handler would set it to 1, but we'd promptly squash that by setting it back to 0 (even though a resize occurred that should be handled). |
|
Date |
User |
Action |
Args |
2015-10-23 02:30:13 | josh.r | set | recipients:
+ josh.r, r.david.murray, neologix, takluyver, martin.panter, Carlos Pita, johnmorr, Eric Price |
2015-10-23 02:30:13 | josh.r | set | messageid: <1445567413.81.0.338813152982.issue23735@psf.upfronthosting.co.za> |
2015-10-23 02:30:13 | josh.r | link | issue23735 messages |
2015-10-23 02:30:13 | josh.r | create | |
|