This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author mwalle
Recipients mwalle
Date 2015-10-07.13:17:10
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1444223830.96.0.970501650084.issue25334@psf.upfronthosting.co.za>
In-reply-to
Content
The process_rawq() discards '\x00' and '\x11' bytes.

At least the '\x00' byte is specified by the standard as a No-Op. So this is standard conform according to RFC 854. But there is also the binary transmission mode for telnet (RFC 856). If I want to support this mode I have to receive these all bytes (just IACs are handled special) and I don't see a possibility to achieve this other that overwriting the process_rawq() method, which essentially means copying it and remove/replace the "if c == theNULL" etc checks. IMHO this is bad, because i copy a 64 lines method, just to modify two lines :(

I'd propose to move these checks to a new method, which then can be overwritten. See attached file for example.
History
Date User Action Args
2015-10-07 13:17:11mwallesetrecipients: + mwalle
2015-10-07 13:17:10mwallesetmessageid: <1444223830.96.0.970501650084.issue25334@psf.upfronthosting.co.za>
2015-10-07 13:17:10mwallelinkissue25334 messages
2015-10-07 13:17:10mwallecreate