Author Erik Cederstrand
Recipients AaronR, Alex.Willmer, BreamoreBoy, Erik Cederstrand, Erik.Cederstrand, aganders3, belopolsky, berker.peksag, r.david.murray, serhiy.storchaka, tim.peters
Date 2015-10-06.10:26:26
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1444127187.19.0.693226234178.issue12006@psf.upfronthosting.co.za>
In-reply-to
Content
I have reviewed the latest patch, and it looks good to me. There are tests for the tricky conversions around Jan 1, and the docs are brief and succinct. Until the full set of new c99 strftime directives are supported, I think it's overkill to include a lecture about the origin of these new directives and their support in the underlying OS.

There are a number of foot-shooting possibilities when parsing date strings with the directives supported by strptime(), but at least this patch does not make it worse. It validates the input nicely when using the new directives and prints useful error messages it input is ambiguous.

I'm not a committer, but I approve of the patch as-is.
History
Date User Action Args
2015-10-06 10:26:27Erik Cederstrandsetrecipients: + Erik Cederstrand, tim.peters, belopolsky, r.david.murray, BreamoreBoy, Erik.Cederstrand, AaronR, aganders3, berker.peksag, serhiy.storchaka, Alex.Willmer
2015-10-06 10:26:27Erik Cederstrandsetmessageid: <1444127187.19.0.693226234178.issue12006@psf.upfronthosting.co.za>
2015-10-06 10:26:27Erik Cederstrandlinkissue12006 messages
2015-10-06 10:26:26Erik Cederstrandcreate