Message252302
The name changes to the function parameters should be avoided without a good reason.
I would recommend rejecting all of the changes in this patch. They are basically changing one person’s coding style to another person’s style. I happen to prefer list() and map() over the list comprehension syntax.
I don’t have a problem with a variable named “type” in a small function. For instance, open_unknown() is only four lines, including signature and doc string! If you can’t easily predict all the variables in a larger function, then I suggest dividing it into smaller components. PEP 8 doesn’t seem to mention the issue of shadowing variable names that I can see anyway. |
|
Date |
User |
Action |
Args |
2015-10-05 04:58:00 | martin.panter | set | recipients:
+ martin.panter, terry.reedy, orsenthil, eric.araujo, r.david.murray, michael.foord, bbrazil |
2015-10-05 04:58:00 | martin.panter | set | messageid: <1444021080.16.0.957413710271.issue15280@psf.upfronthosting.co.za> |
2015-10-05 04:58:00 | martin.panter | link | issue15280 messages |
2015-10-05 04:57:59 | martin.panter | create | |
|