Author vstinner
Recipients ezio.melotti, inada.naoki, python-dev, r.david.murray, serhiy.storchaka, vstinner
Date 2015-09-22.09:06:55
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1442912816.99.0.362017837896.issue24870@psf.upfronthosting.co.za>
In-reply-to
Content
I pushed utf8.patch by mistake :-/ The advantage is that buildbots found bugs. Attached utf8-2.patch fixed bugs.

The bug was how the "s" variable was set in the error handler. It's now set with:

   s = starts + endinpos;

Bugs found by the buildbots:

======================================================================
FAIL: test_invalid_cb_for_3bytes_seq (test.test_unicode.UnicodeTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/opt/python/3.x.langa-ubuntu/build/Lib/test/test_unicode.py", line 1897, in test_invalid_cb_for_3bytes_seq
    'invalid continuation byte')
  File "/opt/python/3.x.langa-ubuntu/build/Lib/test/test_unicode.py", line 1772, in assertCorrectUTF8Decoding
    self.assertEqual(seq.decode('utf-8', 'replace'), res)
AssertionError: '��\x00' != '�\x00'
- ��
? -
+ �

======================================================================
FAIL: test_unquote_with_unicode (test.test_urllib.UnquotingTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/opt/python/3.x.langa-ubuntu/build/Lib/test/test_urllib.py", line 1016, in test_unquote_with_unicode
    "using unquote(): %r != %r" % (expect, result))
AssertionError: '�' != '��'
- �
+ ��
? +
 : using unquote(): '�' != '��'
History
Date User Action Args
2015-09-22 09:06:57vstinnersetrecipients: + vstinner, ezio.melotti, r.david.murray, inada.naoki, python-dev, serhiy.storchaka
2015-09-22 09:06:56vstinnersetmessageid: <1442912816.99.0.362017837896.issue24870@psf.upfronthosting.co.za>
2015-09-22 09:06:56vstinnerlinkissue24870 messages
2015-09-22 09:06:55vstinnercreate