This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author larry
Recipients BreamoreBoy, JohnLeitch, belopolsky, brycedarling, eryksun, georg.brandl, larry, lemburg, paul.moore, python-dev, steve.dower, tim.golden, vstinner, zach.ware
Date 2015-09-07.03:26:12
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1441596372.97.0.536015858012.issue24917@psf.upfronthosting.co.za>
In-reply-to
Content
Okay, I think *I* reproduced it.

1) I pulled your cpython350 fork down locally.

2) I updated to your checkin that fixed the bug. (c31dad22c80d)

3) I reverted the change to Modules/timemodule.c to put the bug back:
   % hg cat -r 97393 Modules/timemodule.c > Modules/timemodule.c

4) I changed line 611 (or so) from "#if defined(MS_WINDOWS) && !defined(HAVE_WCSFTIME)" to "#if 1" so I'd get the code that had the bug.

5) I ran "./configure --with-valgrind && make" to make it.

6) I ran "valgrind ./python -m test test_time" and ***Valgrind complained about an array overrun***.

7) I restored the bugfix to Modules/timemodule.c, then reinstated the change from 4) above.

8) I ran make and valgrind again and didn't get the complaint about the array overrun.

For grins I also tried enabling the other stanza of code that has the bug (the AIX / sun / have_wcsftime) and observed the same thing.

Is that convincing?
History
Date User Action Args
2015-09-07 03:26:13larrysetrecipients: + larry, lemburg, georg.brandl, paul.moore, belopolsky, vstinner, tim.golden, BreamoreBoy, python-dev, zach.ware, eryksun, steve.dower, JohnLeitch, brycedarling
2015-09-07 03:26:12larrysetmessageid: <1441596372.97.0.536015858012.issue24917@psf.upfronthosting.co.za>
2015-09-07 03:26:12larrylinkissue24917 messages
2015-09-07 03:26:12larrycreate