Author vstinner
Recipients Yi Ding, mpaolini, ned.deily, rbcollins, ronaldoussoren, vstinner
Date 2015-09-04.12:12:55
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <CAMpsgwYB=JGuwpbYMSJXVkfLNPD3Ciw6seNdK4=H40jpx3X3oA@mail.gmail.com>
In-reply-to <1441364937.25.0.0266598801626.issue24891@psf.upfronthosting.co.za>
Content
Yes, it looks like a good approach. Some comments:

- please mention this issue "Issue #24891"  and explain the issue in a
comment in create_stdio_checked()
- it would be safer to check the exception type, to be extra safe
- you must clear the exception
- why not putting the code in create_stdio() directly?
History
Date User Action Args
2015-09-04 12:12:55vstinnersetrecipients: + vstinner, ronaldoussoren, rbcollins, ned.deily, mpaolini, Yi Ding
2015-09-04 12:12:55vstinnerlinkissue24891 messages
2015-09-04 12:12:55vstinnercreate