Message249135
The proposed patch directly modifies the copy of Django in the benchmark suite which isn't acceptable; we purposefully don't modify the project code we pull in for benchmark consistency and ease of maintenance.
It would be better to make sure a newer version of Django is fixed upstream, pull in the newer version to the benchmark suite, and then create a django_v3 benchmark using that newer version while removing the django_v2 benchmark from the default set of benchmarks (if not fully remove it).
And can you sign the contributor agreement, Florin? |
|
Date |
User |
Action |
Args |
2015-08-25 16:31:02 | brett.cannon | set | recipients:
+ brett.cannon, pitrou, florin.papa |
2015-08-25 16:31:02 | brett.cannon | set | messageid: <1440520262.3.0.631716009271.issue24934@psf.upfronthosting.co.za> |
2015-08-25 16:31:02 | brett.cannon | link | issue24934 messages |
2015-08-25 16:31:02 | brett.cannon | create | |
|