Author r.david.murray
Recipients Aaron1011, a.badger, berker.peksag, jcea, michael.foord, python-dev, r.david.murray, rbcollins
Date 2015-08-07.15:50:42
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <>
splitlines(keepends=True) is not ever equivalent to splitting by just '\n'.  I don't know the details here, but switching to that would certainly be a behavior change.  (Especially if the code path also applies to non-binary data!):

>>> b'abc\nde\r\nf\x1dg'.splitlines(True)
[b'abc\n', b'de\r\n', b'f\x1dg']
>>> 'abc\nde\r\nf\x1dg'.splitlines(True)
['abc\n', 'de\r\n', 'f\x1d', 'g']
Date User Action Args
2015-08-07 15:50:43r.david.murraysetrecipients: + r.david.murray, jcea, rbcollins, a.badger, michael.foord, python-dev, berker.peksag, Aaron1011
2015-08-07 15:50:42r.david.murraysetmessageid: <>
2015-08-07 15:50:42r.david.murraylinkissue23004 messages
2015-08-07 15:50:42r.david.murraycreate