Author aganders3
Recipients AaronR, Alex.Willmer, BreamoreBoy, Erik Cederstrand, Erik.Cederstrand, aganders3, belopolsky, berker.peksag, r.david.murray, serhiy.storchaka, tim.peters
Date 2015-08-03.03:28:15
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1438572499.88.0.544611504748.issue12006@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks for the review and the good suggestions. Hopefully this new patch is an improvement.

I didn't know about the context manager for assertRaises - I was just following the format for another ValueError test a few lines above.

The frozenset and re-wrapped comment were left from playing around with another way to do the checks, and I've corrected them.

I think the conditionals around calculating the julian and year are clearer now as well.

Please (obviously) let me know if there are further changes. Also please let me know if this is not the proper way to respond to the code review!
History
Date User Action Args
2015-08-03 03:28:20aganders3setrecipients: + aganders3, tim.peters, belopolsky, r.david.murray, BreamoreBoy, Erik.Cederstrand, AaronR, berker.peksag, serhiy.storchaka, Erik Cederstrand, Alex.Willmer
2015-08-03 03:28:19aganders3setmessageid: <1438572499.88.0.544611504748.issue12006@psf.upfronthosting.co.za>
2015-08-03 03:28:19aganders3linkissue12006 messages
2015-08-03 03:28:19aganders3create