Author alex.gronholm
Recipients Yury.Selivanov, alex.gronholm, gvanrossum, scoder, vstinner, yselivanov
Date 2015-08-02.19:30:22
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1438543822.82.0.336164317131.issue24383@psf.upfronthosting.co.za>
In-reply-to
Content
Updated patch per review comments.

I also corrected the order of the lines in the new block. If _must_cancel is True, it would have tried to call cancel() on _fut_waiter before it was set. Now the code matches that of the original block.

The docs don't seem to explicitly say anywhere that they only accept asyncio's Futures and not concurrent Futures, so I'm unsure if any changes are needed there at all.
History
Date User Action Args
2015-08-02 19:30:22alex.gronholmsetrecipients: + alex.gronholm, gvanrossum, scoder, vstinner, Yury.Selivanov, yselivanov
2015-08-02 19:30:22alex.gronholmsetmessageid: <1438543822.82.0.336164317131.issue24383@psf.upfronthosting.co.za>
2015-08-02 19:30:22alex.gronholmlinkissue24383 messages
2015-08-02 19:30:22alex.gronholmcreate