Author berker.peksag
Recipients berker.peksag, michael.foord, pkoning, quasipedia, rbcollins
Date 2015-07-17.05:10:26
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1437109826.73.0.26605748859.issue21750@psf.upfronthosting.co.za>
In-reply-to
Content
LGTM.

A minor comment:

+    def test_mock_open_reuse_issue_21750(self):

We can also add an assert to check the data is actually "data" (e.g. assertEqual(f1.read(), 'data')).
History
Date User Action Args
2015-07-17 05:10:26berker.peksagsetrecipients: + berker.peksag, rbcollins, michael.foord, quasipedia, pkoning
2015-07-17 05:10:26berker.peksagsetmessageid: <1437109826.73.0.26605748859.issue21750@psf.upfronthosting.co.za>
2015-07-17 05:10:26berker.peksaglinkissue21750 messages
2015-07-17 05:10:26berker.peksagcreate