Author barry
Recipients barry, catalin.iacob, jesstess, python-dev, r.david.murray, sandro.tosi, zvyn
Date 2015-07-07.18:25:40
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <20150707142536.271d7f53@limelight.wooz.org>
In-reply-to <1436291967.59.0.147174506029.issue15014@psf.upfronthosting.co.za>
Content
On Jul 07, 2015, at 05:59 PM, R. David Murray wrote:

>I don't see any need to add the is_initial_auth_ok flag.  Either the auth
>method returns something that is not None (initial auth is OK), or it doesn't
>(initial auth is not OK).

I added this because test_smtplib itself expects some challenge/response even
for AUTH PLAIN.  I could have done more surgery on test_smtplib to avoid this,
but on thinking about it, I decided that it makes sense to allow for the
override.  smtplib is often used in test scenarios, so imagine testing an SMTP
server implementation.  To get full coverage you'd want to test both
initial-response and challenge/response even for auth methods like PLAIN.
Indeed, I've been thinking about writing an asyncio-based smtpd, and it would
be nice to be able to handle both cases without having to derive from class
SMTP and re-implementing auth_plain and auth_login.
History
Date User Action Args
2015-07-07 18:25:41barrysetrecipients: + barry, r.david.murray, jesstess, sandro.tosi, catalin.iacob, python-dev, zvyn
2015-07-07 18:25:40barrylinkissue15014 messages
2015-07-07 18:25:40barrycreate