Author martin.panter
Recipients Unit03, berker.peksag, martin.panter, maurosr, milap.py, python-dev, r.david.murray, serhiy.storchaka, taddeimania
Date 2015-07-01.03:58:39
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1435723119.92.0.489998483982.issue23883@psf.upfronthosting.co.za>
In-reply-to
Content
The technical bit of Issue23883_support_check__all__.v3.patch looks pretty good. Mainly some grammar suggestions for the documentation.

Issue23883_test_gettext.v2.patch looks fine; just depends on check__all__() being added.

Couple of comments about the APIs for ftplib and threading. The changes for the other modules all look good though.

Regarding name_of_module, no strong opinion, but maybe keep it as it is for simplicity. You only used it once so far I think anyway.
History
Date User Action Args
2015-07-01 03:58:40martin.pantersetrecipients: + martin.panter, r.david.murray, python-dev, berker.peksag, serhiy.storchaka, milap.py, maurosr, taddeimania, Unit03
2015-07-01 03:58:39martin.pantersetmessageid: <1435723119.92.0.489998483982.issue23883@psf.upfronthosting.co.za>
2015-07-01 03:58:39martin.panterlinkissue23883 messages
2015-07-01 03:58:39martin.pantercreate