Message246024
The technical bit of Issue23883_support_check__all__.v3.patch looks pretty good. Mainly some grammar suggestions for the documentation.
Issue23883_test_gettext.v2.patch looks fine; just depends on check__all__() being added.
Couple of comments about the APIs for ftplib and threading. The changes for the other modules all look good though.
Regarding name_of_module, no strong opinion, but maybe keep it as it is for simplicity. You only used it once so far I think anyway. |
|
Date |
User |
Action |
Args |
2015-07-01 03:58:40 | martin.panter | set | recipients:
+ martin.panter, r.david.murray, python-dev, berker.peksag, serhiy.storchaka, milap.py, maurosr, taddeimania, Unit03 |
2015-07-01 03:58:39 | martin.panter | set | messageid: <1435723119.92.0.489998483982.issue23883@psf.upfronthosting.co.za> |
2015-07-01 03:58:39 | martin.panter | link | issue23883 messages |
2015-07-01 03:58:39 | martin.panter | create | |
|