Message245802
Jacek: If we used the ModuleType check, and somebody adds a module-level constant (like logging.CRITICAL = 50), the test will automatically detect if they forget to update __all__. That is what I meant by the test being stricter. But it looks like you went for the other option, which has its own relative advantages :)
Will try to to a proper review later when I get a chance. |
|
Date |
User |
Action |
Args |
2015-06-25 06:02:58 | martin.panter | set | recipients:
+ martin.panter, r.david.murray, python-dev, berker.peksag, serhiy.storchaka, milap.py, maurosr, taddeimania, Unit03 |
2015-06-25 06:02:58 | martin.panter | set | messageid: <1435212178.76.0.250383041021.issue23883@psf.upfronthosting.co.za> |
2015-06-25 06:02:58 | martin.panter | link | issue23883 messages |
2015-06-25 06:02:58 | martin.panter | create | |
|