This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author vstinner
Recipients mark.dickinson, pitrou, vstinner
Date 2015-06-23.12:26:04
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1435062364.33.0.54187782108.issue24489@psf.upfronthosting.co.za>
In-reply-to
Content
polar_errno.patch doesn't apply cleanly on the default branch, I get that you wrote your patch for Python 3.4.

+    @cpython_only
+    def test_polar_errno(self):
+        # Check a previously set C errno doesn't disturb polar()

Please add the number of this issue in the comment.

+        inf = float('inf')
+ ...
+        nan = float('nan')

On Python 3.5 and 3.6, You can use math.inf and math.nan.

Except of that, the patch looks good to me.
History
Date User Action Args
2015-06-23 12:26:04vstinnersetrecipients: + vstinner, mark.dickinson, pitrou
2015-06-23 12:26:04vstinnersetmessageid: <1435062364.33.0.54187782108.issue24489@psf.upfronthosting.co.za>
2015-06-23 12:26:04vstinnerlinkissue24489 messages
2015-06-23 12:26:04vstinnercreate