Message244574
crash-1.py is due to an unchecked return value from _odictnode_VALUE().
We should probably use PyDict_GetItemWithError(), also in other
places.
I normally try to steer clear of stylistic remarks, but the
_odictnode* macros are hiding too many things. As of now,
they were hiding that an assert() is always true and that a
return value was unchecked.
Also, they're very inconvenient in a debugger. |
|
Date |
User |
Action |
Args |
2015-06-01 10:11:33 | skrah | set | recipients:
+ skrah, rhettinger, gregory.p.smith, ncoghlan, pitrou, scoder, eric.smith, benjamin.peterson, ned.deily, ezio.melotti, eric.araujo, mrabarnett, Arfrever, alex, asvetlov, flox, BreamoreBoy, Mark.Shannon, python-dev, eric.snow, Jim.Jewett, serhiy.storchaka, yselivanov, steve.dower, westurner, refi64, josh.r, tonn81, introom |
2015-06-01 10:11:33 | skrah | set | messageid: <1433153493.27.0.82428649796.issue16991@psf.upfronthosting.co.za> |
2015-06-01 10:11:33 | skrah | link | issue16991 messages |
2015-06-01 10:11:32 | skrah | create | |
|