Author skrah
Recipients Arfrever, BreamoreBoy, Jim.Jewett, Mark.Shannon, alex, asvetlov, benjamin.peterson, eric.araujo, eric.smith, eric.snow, ezio.melotti, flox, gregory.p.smith, introom, josh.r, mrabarnett, ncoghlan, ned.deily, pitrou, python-dev, refi64, rhettinger, scoder, serhiy.storchaka, skrah, steve.dower, tonn81, westurner, yselivanov
Date 2015-06-01.10:11:32
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1433153493.27.0.82428649796.issue16991@psf.upfronthosting.co.za>
In-reply-to
Content
crash-1.py is due to an unchecked return value from _odictnode_VALUE().

We should probably use PyDict_GetItemWithError(), also in other
places.

I normally try to steer clear of stylistic remarks, but the
_odictnode* macros are hiding too many things.  As of now,
they were hiding that an assert() is always true and that a
return value was unchecked.

Also, they're very inconvenient in a debugger.
History
Date User Action Args
2015-06-01 10:11:33skrahsetrecipients: + skrah, rhettinger, gregory.p.smith, ncoghlan, pitrou, scoder, eric.smith, benjamin.peterson, ned.deily, ezio.melotti, eric.araujo, mrabarnett, Arfrever, alex, asvetlov, flox, BreamoreBoy, Mark.Shannon, python-dev, eric.snow, Jim.Jewett, serhiy.storchaka, yselivanov, steve.dower, westurner, refi64, josh.r, tonn81, introom
2015-06-01 10:11:33skrahsetmessageid: <1433153493.27.0.82428649796.issue16991@psf.upfronthosting.co.za>
2015-06-01 10:11:33skrahlinkissue16991 messages
2015-06-01 10:11:32skrahcreate