Author eric.snow
Recipients Arfrever, Jim.Jewett, Mark.Shannon, alex, asvetlov, benjamin.peterson, eric.araujo, eric.smith, eric.snow, ezio.melotti, flox, gregory.p.smith, introom, josh.r, mrabarnett, ncoghlan, ned.deily, pitrou, python-dev, refi64, rhettinger, scoder, serhiy.storchaka, tonn81, westurner, yselivanov
Date 2015-05-30.15:40:11
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <CALFfu7C2SgAzjBxh=+gdZyqCRXTsOyCByJpzfUfyLvRxFpjHNw@mail.gmail.com>
In-reply-to <1705079.8CgS8uXsvX@raxxla>
Content
> PyObject_TypeCheck() should be used instead of PyObject_IsInstance() (see
> issue24257).

Thanks for pointing this out.  I've fixed both dictobject.h and odictobject.h.

>
> Perhaps Py_ODict_GetItemId() should be private API as relevant dict function.

This isn't needed for 3.5, right?  I'm not opposed to adding more
functions to the C API for OrderedDict, but I wanted to start out as
small as possible.  My main motivation for the C implementation was
for use in the interpreter and I hadn't given much thought to the
direct use of C OrderedDict by extension modules.  That can be
addressed in 3.6 if it's important.  I supposed you could double-check
with Larry if you want to add more odict support to the C-API for 3.5.
History
Date User Action Args
2015-05-30 15:40:11eric.snowsetrecipients: + eric.snow, rhettinger, gregory.p.smith, ncoghlan, pitrou, scoder, eric.smith, benjamin.peterson, ned.deily, ezio.melotti, eric.araujo, mrabarnett, Arfrever, alex, asvetlov, flox, Mark.Shannon, python-dev, Jim.Jewett, serhiy.storchaka, yselivanov, westurner, refi64, josh.r, tonn81, introom
2015-05-30 15:40:11eric.snowlinkissue16991 messages
2015-05-30 15:40:11eric.snowcreate