Author rhettinger
Recipients pitrou, rhettinger, serhiy.storchaka, vstinner
Date 2015-05-12.22:55:52
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1431471352.66.0.671884988107.issue23290@psf.upfronthosting.co.za>
In-reply-to
Content
Attaching a variant with several fix-ups (mostly minor):

* Changed the order of the three sections to go from most-restricted-most-optimized to the general-fall-through case.  The downside is that we test so->fill==0 twice.  The upside is that it corresponds to my way of thinking about the logic.

* Put the fill/used increments in the same order as the rest of the file.

* Loop over other_entry++ instead of using indexing.  This corresponds to my way of thinking about the entries and gives the compiler a stronger hint that it can avoid the indexing overhead.

* Removed the unnecessary dummy check from the direct_pointer_copy case.

* Switch the order of the same size and no dummies tests in the insert_clean case.

* Revise the comments to be clearer about the requirements for each case.

* Move the sometimes unnecessary hash variable assignments inside the conditional.
History
Date User Action Args
2015-05-12 22:55:52rhettingersetrecipients: + rhettinger, pitrou, vstinner, serhiy.storchaka
2015-05-12 22:55:52rhettingersetmessageid: <1431471352.66.0.671884988107.issue23290@psf.upfronthosting.co.za>
2015-05-12 22:55:52rhettingerlinkissue23290 messages
2015-05-12 22:55:52rhettingercreate